Helloooooooo !!

> From what I understand, Dima is more concerned about future extendability
of
> the function.

We do not write C code. We can add new optional argument whenever we want.

> If someone comes along with a different construction two years
> from now then that person can simply set a different type and the same
> function will work. Right *now*, there is no advantage other than the
> prospect of being maintainable and extendable in the far future.

The same function will work even if we do not add it, for the reason given
above.

This being said, I know how to recognize real art when I see it. I added
the new argument and the ticket is updated.

I also ensured that nothing wrong happened :

+    if type != "Desarguesian":
+        raise ValueError("The value of 'type' must be 'Desarguesian'.")

And of course I double-checked this exception in a doctest :

+    TESTS::
+
+        sage: designs.ProjectivePlaneDesign(10, type="AnyThingElse")
+        Traceback (most recent call last):
+        ...
+        ValueError: The value of 'type' must be 'Desarguesian'.

I feel better now.

Nathann

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to