#13501: Fix two bugs in sage.misc.c3's implementation of the algorithm C3
-------------------------------------------------+--------------------------
Reporter: nthiery | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.4
Component: categories | Resolution:
Keywords: method resolution order | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Nicolas M. Thiéry, Simon King | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by nthiery):
Replying to [comment:33 SimonKing]:
> Could it be that the error message randomly choses between "Cannot
create ... for bases B, C" and "Cannot create ... for bases C, B"?
That sounds a bit strange indeed (I would have expected C3 to be
completely deterministic, including in its error messages), but I
vaguely remember having to change this order once.
> If that is the case, I suggest to change the expected error message
> into "Cannot create a consistent method resolution order (MRO) for
> bases ..."
+1
I just did that. I used the occasion to avoid using a temporary
``tail_set`` variable, as recommended by your benchmark. See
[attachment:trac_13501-c3-review-nt.patch] for the changes. The
updated [attachment:trac_13501-categories-c3_fix-nt.patch] contains
all three patches folded together.
Apply:
* [attachment:trac_13501-categories-c3_fix-nt.patch]
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13501#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
