#13501: Fix two bugs in sage.misc.c3's implementation of the algorithm C3
-------------------------------------------------+--------------------------
       Reporter:  nthiery                        |         Owner:              
           Type:  defect                         |        Status:  needs_review
       Priority:  major                          |     Milestone:  sage-5.4    
      Component:  categories                     |    Resolution:              
       Keywords:  method resolution order        |   Work issues:              
Report Upstream:  N/A                            |     Reviewers:  Simon King  
        Authors:  Nicolas M. ThiƩry, Simon King  |     Merged in:              
   Dependencies:  #12895                         |      Stopgaps:              
-------------------------------------------------+--------------------------

Comment (by SimonKing):

 Replying to [comment:28 nthiery]:
 > There is a failure in sage_object, probably trivial/unrelated, but I
 haven't looked at it yet; I need to take of now!

 The error is when unpickling stuff. In principle, a different mro could
 change things. On the other hand, this should only affect parent and
 element classes of categories - and they are pickled by construction
 (hence, it is not the case that the mro is stored in the pickle).

 Anyway, I get:
 {{{
 ./sage -t devel/sage/sage/structure/sage_object.pyx
 sage -t  "devel/sage/sage/structure/sage_object.pyx"
          [11.5 s]

 ----------------------------------------------------------------------
 All tests passed!
 Total time for all tests: 11.5 seconds
 }}}
 with
 {{{
 trac_715_combined.patch
 trac_715_local_refcache.patch
 trac_715_safer.patch
 trac_715_specification.patch
 trac_11521_homset_weakcache_combined.patch
 trac_11521_callback.patch
 13145.patch
 trac_13447-sanitise_ring_refcount.patch
 trac12215_weak_cached_function-sk.patch
 trac12215_segfault_fixes.patch
 trac_12313-mono_dict-combined-random-sk.patch
 trac_12313_quit_sage.patch
 trac13370_deprecate_is_field.patch
 trac_13378-convert_map_shortcut.patch
 trac_13412_category_for_power_series_rings.patch
 trac_13501-categories-c3_fix-nt.patch
 trac_13501-c3-speedup-sk.patch
 trac_12876_category_abstract_classes_for_hom.patch
 trac_12876_r_test.patch
 }}}
 applied on top of sage-5.4.beta0.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13501#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to