#13501: Fix two bugs in sage.misc.c3's implementation of the algorithm C3
-------------------------------------------------+--------------------------
Reporter: nthiery | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: categories | Resolution:
Keywords: method resolution order | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Nicolas M. Thiéry, Simon King | Merged in:
Dependencies: #12895 | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by SimonKing):
Replying to [comment:23 nthiery]:
> I am almost ready for a postive review (assuming the patchbot goes
green).
Will it ever go green? Does the patchbot work at all.
> Two little questions: what happens if
>
> - we use id(cat) rather than the obscure <size_t><void *> cat ?
>
> - we use ``O in <set>tailsets[j]`` rather than assigning to a temporary
variable?
I guess you mean `id(O) in <set>tailsets[j]`
{{{
ncalls tottime percall cumtime percall filename:lineno(function)
7000/500 0.207 0.000 0.672 0.001 {sage.misc.c3.C3_algorithm}
}}}
instead of
{{{
ncalls tottime percall cumtime percall filename:lineno(function)
7000/500 0.196 0.000 0.663 0.001 {sage.misc.c3.C3_algorithm}
}}}
> In both cases, if the speed is roughly equivalent, then I vote for the
more readable version.
Is the difference (again 5%) marginal? Anyway, I can only do it tomorrow.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13501#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
