#13072: Implementation of PartitionTuple + some minor fixes to partition.py
----------------------------------------+-----------------------------------
Reporter: andrew.mathas | Owner: Andrew Mathas
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: tuples of partitions | Work issues:
Report Upstream: N/A | Reviewers: Travis Scrimshaw
Authors: Andrew Mathas | Merged in:
Dependencies: #9265, #11446 | Stopgaps:
----------------------------------------+-----------------------------------
Changes (by hivert):
* status: positive_review => needs_work
Comment:
Hi Andrew and Travis,
Thanks both for your work. I'm hate to switch back to needs works but
looking at the compiled doc, I see various small problems which should be
fixed. Here are some of them:
- Don't indent bulleted list. It adds an extra uneeded indentation (see
e.g. REFERENCE vs AUTHORS in the module class;
- There is a proper markup for references (see developper guide);
- In the doc of the class {{{PartitionTuple}}}, there is a miss
indentation between {{{INPUT}}} and {{{EXAMPLES:}}}
- in the doc of {{{Garnir_tableau}}} please write {{{``self``}}}
{{{``cell``}}}, {{{``FALSE``}}} ... (verbatim set-up) but don't forget
single back-quote for {{{`(k,a+1,c)`}}} (latex set-up) and similar. The
hyperlink in SEE ALSO are missing
- There is a proper markup for linking to trac ticket eg:
{{{:trac:`13123`}}}
- There is a typo in "The Garnir tableau are the “first” non-standard
tableaux which arise when you at by simple transpositions."
Sorry for being picky for the doc. If it wasn't so late et France, I would
have written a review patch.
For Travis: please check the compiled doc when your are reviewing a patch.
You can refer to {{{http://wiki.sagemath.org/ReviewChecklist}}}.
Cheers,
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13072#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
