#12339: Free Groups
--------------------------------+-------------------------------------------
Reporter: mmarco | Owner: joyner
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.5
Component: group theory | Resolution:
Keywords: free groups | Work issues:
Report Upstream: N/A | Reviewers: Volker Braun
Authors: Miguel Marco | Merged in:
Dependencies: #6391 | Stopgaps:
--------------------------------+-------------------------------------------
Comment (by vbraun):
This is a really nice contribution!
`ParentWithGens` is deprecated, see the beginning of
`sage/structure/parent_gens.pyx`. You should use `Parents.__init__(self,
gens=..., category=Groups())` or so. I know thats not as well-documented
as it should be. You do already import `Groups` but don't use it. Did you
have any problems with the new parents?
For comparison you should override `_cmp_` in elements, otherwise you
circumvent the coercion system.
Another minor issue, don't use catch-all `except:`. You almost certainly
don't want to catch `KeyboardInterrupt`, for example. Use `except
StandardError:` to catch all ''errors''.
Since there isn't any example yet for how to use libGAP, I though it would
be nice to use the finitely generated groups to demonstrate what it can be
used for. Do you have any other patches that you have already based on
this ticket? Otherwise I'd like to make some changes to use libgap better.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12339#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
