#13731: Fix libsingular memory management
---------------------------+------------------------------------------------
       Reporter:  nbruin   |         Owner:  rlm     
           Type:  defect   |        Status:  new     
       Priority:  major    |     Milestone:  sage-5.6
      Component:  memleak  |    Resolution:          
       Keywords:           |   Work issues:          
Report Upstream:  N/A      |     Reviewers:          
        Authors:           |     Merged in:          
   Dependencies:           |      Stopgaps:          
---------------------------+------------------------------------------------

Comment (by nbruin):

 Replying to [comment:13 SimonKing]:
 > So, the missing header is actually is created.

 Yes, indeed, and that is the one I copy over manually because I didn't
 figure out how to do it in the install script (that should be
 straightforward though)

 > Also, I don't understand why `omMalloc.h` is needed: In a previous Sage
 installation with the standard Singular 3-1-5 package, I can't find
 `omMalloc.h` in `SAGE_ROOT/local/...`.

 It might not be. The reason why it is needed now is because of the rough
 way I mutilated the omalloc source in Singular. Its configuration process
 is a big tangle of pasting together header files, so when I finally found
 a way to effect the desired changes I was already happy. That involved
 knocking out some `#ifdef ... #endif` preprocessor directives in the
 source. I'm sure it's straightforward to fix that a little more nicely (I
 wasn't aiming for production code at the time, just a quick tool to debug
 stuff). That activated a `#include <omalloc/omAlloc.h>` as well.
 I don't know if errors happen if you delete that line.
 Anyway, the `libsingular*.pyx` files import the header file in which that
 include ends up, so that's why presently, that file needs to be in the
 include paths used by `sage -b`.

 I wasn't understating when I called the package rather untidy ...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13731#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to