#12518: Enumerated set from iterator
-------------------------------------+--------------------------------------
       Reporter:  vdelecroix         |         Owner:  vdelecroix  
           Type:  enhancement        |        Status:  needs_review
       Priority:  major              |     Milestone:  sage-5.6    
      Component:  combinatorics      |    Resolution:              
       Keywords:  set, iterator      |   Work issues:              
Report Upstream:  N/A                |     Reviewers:  PatchBot    
        Authors:  Vincent Delecroix  |     Merged in:              
   Dependencies:  #12653             |      Stopgaps:              
-------------------------------------+--------------------------------------

Comment (by vdelecroix):

 Hi Travis,

 > I also get the patchbot errors when running the patch in the combinat
 queue on 5.5.rc0. Also from a quick look-through the patch, there are a
 few things which I believe needs to be addressed:
 > - Documentation and tests for the deprecated functions in
 `combinat/combinat.py`

 These functions were *only* in the sage-combinat queues and not inside
 Sage. So the deprecation is just intended for people from combinat who
 were using it (and I think that none of them uses it).

 > - An example in `iter_with_cache()`, I also don't quite understand the
 documentation.

 I will open (few days) a new ticket for a better implementation of
 iter_with_cache. There is a similar construction in lazy power series and
 I would like to merge both. The idea is to have a Python data structure
 that behave like a list but with possibly infinitely many entries.

 > - I prefer to see the reserved words in code blocks: {{{``None``}}},
 {{{``self``}}}, {{{``True``}}}, and {{{``False``}}}

 Is there a difference for documentation ? I thought that code blocks open
 a new paragraph.

 Thanks for careful reading, I will adress all remarks in a new patch.

 Best,
 Vincent

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12518#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to