#12518: Enumerated set from iterator
-------------------------------------+--------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: combinatorics | Resolution:
Keywords: set, iterator | Work issues:
Report Upstream: N/A | Reviewers: PatchBot
Authors: Vincent Delecroix | Merged in:
Dependencies: #12653 | Stopgaps:
-------------------------------------+--------------------------------------
Comment (by tscrim):
Hey Vincent,
I also get the patchbot errors when running the patch in the combinat
queue on 5.5.rc0. Also from a quick look-through the patch, there are a
few things which I believe needs to be addressed:
- Documentation and tests for the deprecated functions in
`combinat/combinat.py`
- An example in `iter_with_cache()`, I also don't quite understand the
documentation.
- You'll need to add `iter_with_cache` and `set_from_iterator` to the
documentation by adding/editing a `.rst` file (probably `misc.rst`).
- I prefer to see the reserved words in code blocks: {{{``None``}}},
{{{``self``}}}, {{{``True``}}}, and {{{``False``}}}
- Same for input parameters and private functions, even in private
functions.
- I prefer to have as much linking as possible: ex.
{{{:class:`EnumeratedSetFromIterator`}}}
- Instead of
{{{#!python
if x is True:
...
if x is False:
...
}}}
it is better to do
{{{#!python
if x:
...
if not x:
...
}}}
in case `x` is not a boolean (ex. `x = 1`).
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12518#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
