#12518: Enumerated set from iterator
-------------------------------------+--------------------------------------
       Reporter:  vdelecroix         |         Owner:  vdelecroix      
           Type:  enhancement        |        Status:  needs_review    
       Priority:  major              |     Milestone:  sage-5.6        
      Component:  combinatorics      |    Resolution:                  
       Keywords:  set, iterator      |   Work issues:                  
Report Upstream:  N/A                |     Reviewers:  Travis Scrimshaw
        Authors:  Vincent Delecroix  |     Merged in:                  
   Dependencies:  #12653, #13778     |      Stopgaps:                  
-------------------------------------+--------------------------------------
Changes (by tscrim):

  * reviewer:  PatchBot => Travis Scrimshaw


Comment:

 Hey Vincent,

 I'm uploading a review patch which just makes some documentation tweaks.
 Functionally it looks good.

 However I would like those functions in `combinat/combinat.py` removed
 since they only exist in your patch (I grep'ed the patches in the queue
 and only found them in this patch), and I believe we don't need to follow
 the sage deprecation scheme within the combinat queue (please correct me
 if I'm wrong). If you're worried about it, I would place the functions in
 a separate patch.

 Thank you,[[BR]]
 Travis

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12518#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to