#14138: some cleanup in sage.combinat.combinat
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Changes (by nthiery):
* status: positive_review => needs_work
Comment:
Hi Nathann!
Thanks much for the cleanup!
A couple details:
- What's the reason for removing the doctests about
cyclic_permutations_of_partition and cyclic_permutations?
- Don't deprecate min_part in Partitions. Even if fragile, it is
useful in some cases, and we will want to support robustly at some
point. The documentation warns the user.
Besides, Partitions is under heavy refactoring by #13605 which will
get into Sage soon; we don't want conflict with that.
- While you are at removing a space in sage/combinat/multichoose_nk.py,
you might as well remove the comma before :-)
- Please check the discussion on sage-combinat-devel about
number_of_partitions; I don't remember whether we decided we wanted
to deprecate it or not.
- ``See http://trac.sagemath.org/14138 for details'' Please use
:trac:`14138`.
Besides, if the user is referred to the ticket, then the ticket
should be more explicit not only about what you don't like, but what
the ticket actually does about it.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14138#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
