#14138: some cleanup in sage.combinat.combinat
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by nthiery):
Replying to [comment:16 ncohen]:
> I wrote that above. The reason is that the code changed as it now calls
what it should have been calling in the first place, and this doctests
which says that "the behaviour is not the one that we usually expect" has
apprently become what one would expect. Correct it if it is wrong.
Fair enough. I missed the one line change in the code. Thanks for fixing
this!
Please add a doctest for the new behavior stating something like:
"repetitions are handled properly since #...."
> This ticket was positively reviewed yesterday, your ticket #13605 is 4
months old, is needing a review, weighs 400kb and depends on another
ticket #13688 which also needs a review. Why the hell would you delay this
one instead and have us work on top of yours ?
I never said it should wait for #13605.
> > - Please check the discussion on sage-combinat-devel about
> > number_of_partitions; I don't remember whether we decided we wanted
> > to deprecate it or not.
> `number_of_partitions` has been deprecated by #13072.
Perfect. Thanks for checking this out.
> > - ``See http://trac.sagemath.org/14138 for details'' Please use
:trac:`14138`.
>
> This is no Sphinx code. This is a deprecation warning, automatically
generated by the `deprecation()` function.
Good point.
> What I do not like in this ticket should be obvious to everybody. Just
read the code sample and the documentation I quoted.
Thanks for adding a description. I might be stupid, but I was missing this
information.
> This ticket has been created, written and reviewed in three days. It is
very short.
You can set it back to positive review as soon as the little things above
are resolved. Thanks for handling this in such a prompt manner.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14138#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
