#14138: some cleanup in sage.combinat.combinat
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ppurka):
@nthiery: This ticket is mostly orthogonal in functionality to the work in
#14019. Most of the changes are in combinat.py which is largely untouched
by that ticket. This ticket should not be based on #14019.
About `min_part=0` - the warning has been present since early 2009. That's
nearly four years. I think it is about time it should either be allowed to
have this ''value 0'' in the parameter, or be deprecated. There are no
doctests/examples in the file which show ''when'' it produces wrong
results. If the user has no idea when this gives correct results or when
it gives wrong results, it should be removed.
Please set this back to positive review, unless there are more compelling
reasons to base it on #14019.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14138#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
