#14138: some cleanup in sage.combinat.combinat
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by nthiery):
Replying to [comment:18 ppurka]:
> @nthiery: This ticket is mostly orthogonal in functionality to the work
in #13605. Most of the changes are in combinat.py which is largely
untouched by that ticket. This ticket should not be based on #13605.
I totaly agree: it should not depend on #13605! I am just pointing out
that, for a minor change that is debatable, it might not be worth creating
a conflict.
> About `min_part=0` - the warning has been present since early 2009.
That's nearly four years. I think it is about time it should either be
allowed to have this ''value 0'' in the parameter, or be deprecated. There
are no doctests/examples in the file which show ''when'' it produces wrong
results. If the user has no idea when this gives correct results or when
it gives wrong results, it should be removed.
As you wish, as long as you promise to support those users that are using
this option,
in full knowledge of the risks they were taking, when it will actually be
removed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14138#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
