#14826: Newton polygons
-----------------------------------+---------------------------
Reporter: caruso | Owner: roed
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-5.12
Component: padics | Resolution:
Keywords: Newton polygons | Merged in:
Authors: Xavier Caruso | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Dependencies: #14987
Stopgaps: |
-----------------------------------+---------------------------
Comment (by vbraun):
You must never use the bare element class (`NewtonPolygon_class` in your
case). Always use `parent.element_class`
{{{
sage: from sage.combinat.newton_polygon import *
sage: NewtonPolygon_element
<class 'sage.combinat.newton_polygon.NewtonPolygon_element'>
sage: ParentNewtonPolygon().element_class
<class
'sage.combinat.newton_polygon.ParentNewtonPolygon_with_category.element_class'>
}}}
My patch fixes that, and `_add_` is now called the way it is supposed to.
Various docstrings need to be formatted according to
http://www.sagemath.org/doc/developer/conventions.html#docstring-markup-
with-rest-and-sphinx
Also, you need to get to 100% coverage:
{{{
$ sage -coverage sage/combinat/newton_polygon.py
------------------------------------------------------------------------
SCORE sage/combinat/newton_polygon.py: 82.6% (19 of 23)
Missing documentation:
* line 656: def _an_element_(self)
Missing doctests:
* line 488: def plot(self, **kwargs)
* line 650: def _repr_(self)
* line 659: def _element_constructor_(self, arg, sort_slopes=True,
last_slope=Infinity)
------------------------------------------------------------------------
}}}
I would put the file in `sage/geometry` instead of `sage/combinat`.
--
Ticket URL: <http://trac.sagemath.org/ticket/14826#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
