#14826: Newton polygons
-----------------------------------+-----------------------------
       Reporter:  caruso           |         Owner:  roed
           Type:  enhancement      |        Status:  needs_review
       Priority:  major            |     Milestone:  sage-5.12
      Component:  padics           |    Resolution:
       Keywords:  Newton polygons  |     Merged in:
        Authors:  Xavier Caruso    |     Reviewers:
Report Upstream:  N/A              |   Work issues:
         Branch:                   |  Dependencies:
       Stopgaps:                   |
-----------------------------------+-----------------------------

Comment (by jantuitman):

 nice and useful code!

 after testing a bit myself I only found one possible issue:

 self._lastslope has not necessarily been set when it is used on line 602
 resulting in bug in plot()

 sage: NP=NewtonPolygon([(0,0),(1,0)],last_slope=2)
 sage: NP.plot()

 there are also some unimportant typos like:

 line 85: explicitly mentioned
 line 90: greater than or equal to
 line 272: is infinite
 line 351: are the union of those
 line 614: image of this

 I hope this is useful, I'm currently at the SAGE days in Leiden and using
 this as practice

--
Ticket URL: <http://trac.sagemath.org/ticket/14826#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to