#5778: [with patch; needs review] Get p-adic doctest coverage to 100% (depends
on
#5105)
--------------------+-------------------------------------------------------
Reporter: roed | Owner: roed
Type: defect | Status: new
Priority: major | Milestone: sage-4.0
Component: padics | Keywords: doctests
--------------------+-------------------------------------------------------
Comment(by robertwb):
First, the patches can't be partially applied and used one at a time. But
it is better than one monolithic patch.
OK, the first two patches (outside-padics and deletions/moving look good).
I'm all for a generic_nodes.py rather than a dozen files with three lines
in them each (it makes it a lot easier to trace the code for instance).
I'm most of the way through padic_doctests_1.patch--it looks good for the
most part. Lots of the patch is whitespace/line wrapping--it would be nice
to be able to filter stuff like this out better for review purposes.
There's a fair amount of commenting stuff out/ReSTification as well, and
new doctests. The only issues I've found are
sage/rings/padics/eisenstein_extension_generic.py:97 - typo "extensinos"
sage/rings/padics/factory.py:2323: def krasner_check(poly, prec): always
returns True, but comments state that it's really not implemented, which
is a bit worrisome.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5778#comment:36>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
