#5778: [with patch; needs review] Get p-adic doctest coverage to 100% (depends 
on
#5105)
--------------------+-------------------------------------------------------
 Reporter:  roed    |       Owner:  roed    
     Type:  defect  |      Status:  new     
 Priority:  major   |   Milestone:  sage-4.0
Component:  padics  |    Keywords:  doctests
--------------------+-------------------------------------------------------

Comment(by robertwb):

 Some general remarks:

  * The {{{AUTHORS}}} block is not a verbatim/code block, no need for
 double colons.

  * Several docstrings are duplicated in their entirety, e.g. for a cdef
 function and its testing function. There really should just be one copy of
 the docstring, and the other should reference the first.

  * Some examples, e.g. for {{{_div_}}} could be more illustrative (e.g.
 showing that div produces multiplicative inverses would be interesting, as
 would dividing by non-units).

  * I like that there is some variety in the primes used, including big
 ones, but I would like to see more variety in the extension fields used.
 The field Q_5(a) where a is a root of {{{f = x^5 + 75*x^3 - 15*x^2 +125*x
 - 5}}} is used in nearly every example (i.e. over 150 times).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5778#comment:39>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to