#5778: [with patch; needs review] Get p-adic doctest coverage to 100% (depends
on
#5105)
--------------------+-------------------------------------------------------
Reporter: roed | Owner: roed
Type: defect | Status: new
Priority: major | Milestone: sage-4.0
Component: padics | Keywords: doctests
--------------------+-------------------------------------------------------
Comment(by robertwb):
Some more comments:
'''padic_doctests_2.patch'''
looks good, again, mostly rest/whitespace changes.
'''padic_doctests_3.patch'''
* {{{sage/rings/padics/padic_ZZ_pX_element.pyx:74}}} extraneous print
statements
* {{{sage/rings/padics/padic_base_generic.py::33}}} generic
{{{__reduce__}}} commented out, should probably be outright deleted if
it's not used (do subclasses always override this?)
* {{{sage/rings/padics/padic_base_generic_element.pyx:43}}} (nitpicky) I
think it's easier to read
{{{
"%s + O(%s^%s)" % (self.lift(), self.parent().prime(),
self.precision_absolute())
}}}
than
{{{
self.lift().str() + " + O(" + self.parent().prime().str() + "^" +
self.precision_absolute().str() + ")"
}}}
Also, something I just noticed (not part of this patch). The functions
{{{_set_to_mpz}}}, {{{_set_to_mpq}}} don't change self (as one would
expect) but set the input parameter. Perhaps {{{_set_mpz_to}}} or
something similar would be better.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5778#comment:37>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
