#14711: Memleak when creating QuadraticField
-------------------------------------+-------------------------------------
Reporter: jpflori | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.13
Component: number fields | Resolution:
Keywords: memleak, number | Merged in:
field, QuadraticField | Reviewers:
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5168cfd15d4cdbaa3ffdbd4be0f7d783f77257c7
u/SimonKing/ticket/14711 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:111 SimonKing]:
> Perhaps it would be better to focus here on fixing the memory leak
(which, I think succeeded), only documenting with examples that it has
worked.
>
> Hence, on ''this'' ticket, I would just
> - provide missing docs for `SchemeMorphism`
Done in the current commit.
> - Perhaps: Re-introduce a cdef public attribute _codomain, since this
would allow faster access than calling .codomain(), and since the codomain
will be strongly referenced anyway.
Done in the current commit.
In addition, I changed the generic `__copy__` method of maps so that it
uses `_update_slots` and `_extra_slots`. This complies with how currently
pickling is implemented by default. For several types of maps, I
implemented copying accordingly.
> - Let the string representation of a weakened map consist of a warning
to not use this map outside of the coercion framework.
Still todo.
> Everything else should perhaps better be done on a follow-up ticket:
> - Add documentation explaining the current weak coercion model, to
facilitate maintanance,
> - Add `permanent=True` option to `register_coercion()`.
Do you agree that this shall be on a different ticket?
--
Ticket URL: <http://trac.sagemath.org/ticket/14711#comment:115>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
