#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: None of the above | Work issues:
- read trac for reasoning. | Commit:
Branch: | c3dba989f73c1eec0a66cf72ae203132fe33b5da
u/SimonKing/ticket/13394 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Simon King', 'oldvalue': ''}):
* status: new => needs_review
* author: => Simon King
* upstream: N/A => None of the above - read trac for reasoning.
Comment:
With the current commits, `weakref.WeakValueDict` is replaced by
`sage.misc.weak_dict.WeakValueDict` everywhere in Sage. All doc tests
pass. The doctest coverage of the new module is 100%.
Hence, I make it "needs review", and we will see whether we will report
upstream.
Next, I'll try to construct finer grained benchmarks, to see if there are
aspects in which the implementation in `weakref` is still better.
----
New commits:
||[changeset:c3dba98]||Replace weakref.WeakValueDictionary by
sage.misc.weak_dict.WeakValueDictionary||
||[changeset:17b0236]||Documentation for WeakValueDictionary||
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
