#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: None of the above | Work issues:
- read trac for reasoning. | Commit:
Branch: | c3dba989f73c1eec0a66cf72ae203132fe33b5da
u/SimonKing/ticket/13394 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Even though all tests pass, I wonder about one implementation detail. The
callback for `weakref.WeakValueDictionary` looks like this:
{{{
def remove(wr, selfref=ref(self)):
self = selfref()
if self is not None:
del self.data[wr.key]
}}}
Hence, the callback has a weak reference to the dictionary. In my
implementation, it is just a method.
Why is a weak self-reference needed? Is this just to prevent problems that
could arise when one of the internally used weak references creeps out of
the dict?
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
