#15367: Empty lists while creating parents
-------------------------------------+-------------------------------------
       Reporter:  roed               |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-5.13
      Component:  coercion           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nils Bruin         |    Reviewers:  Simon King
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/nbruin/ticket/15367              |  cce61195a94ce70f27c0a3efeafbccf4f190f5f0
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by SimonKing):

 Can you elaborate: What is `PyCapsule`? I've never heard of it.

 Would it make sense to have `cdef type fixed_KeyedRef=KeyedRef` instead of
 just `cdef fixed_KeyedRef=KeyedRef`? After all, we do "isinstance" for a
 couple of times, so, it might help Cython if it knows that `KeyedRef`
 actually ''is'' a type.

 Concerning the hash function: Didn't we have the current hash function
 `<size_t>key1 + 13*(<size_t>key2) ^ 503*(<size_t>key3)` in the original
 implementation? If I recall correctly, I chose it because it was
 recommended as a good hash function for tuples. Why did you (temporarily?)
 change it to `<size_t>key1 + (<size_t>key2)<<2 + (<size_t>key3)<<4`?

--
Ticket URL: <http://trac.sagemath.org/ticket/15367#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to