#15382: Implementing Macaulay Resultant (sage days 55)
-------------------------------------------------+-------------------------
Reporter: haochen_uw | Owner:
Type: task | Status:
Priority: major | needs_work
Component: algebraic geometry | Milestone: sage-5.13
Keywords: Macaulay Resultant sage- | Resolution:
days55 | Merged in:
Authors: Soli Vishkautsan, Hao Chen | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------------------------+-------------------------
Changes (by bhutz):
* status: needs_review => needs_work
Comment:
I haven't had a chance to look at the algorithm yet, but I browsed through
the code in the patch and there a couple things.
1) Instead of adding .n.patch for each new version, unless the new version
is drastically different simply replace the previous patch with the new
one.
2) add a comment "apply patch.name" to specify which patch should be
applied
Actually in the code:
3)Replace the 'assert' which are raising AssertionError, with a 'raise'
statement and something more meaning full like TypeError or ValueError
4) The monomials() function takes as input the ring it is creating the
monomials over. This seems like it should be a member function of the
appropriate polynomial ring class instead of a stand-alone function
(assuming it isn't already implemented).
5) I'm still debating whether I think macalauy_resultant should also be a
member function of some polynomial ring. I'm inclined to say it should be
(since resultant() is) but I'm open to arguments against.
6) It appears you can pass in a bunch of polynomials from all different
polynomial rings and it won't detect the problem (you just get the parent
of the first flist element).
That's all for now. I still need actually look at the algorithm...
--
Ticket URL: <http://trac.sagemath.org/ticket/15382#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
