#15382: Implementing Macaulay Resultant (sage days 55)
-------------------------------------+-------------------------------------
Reporter: haochen_uw | Owner:
Type: task | Status: needs_work
Priority: major | Milestone: sage-5.13
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: Macaulay | Reviewers:
Resultant sage-days55 | Work issues:
Authors: Soli Vishkautsan, | Commit:
Hao Chen | 32fa6c14411947b49bf32c3b6be176575bade538
Report Upstream: N/A | Stopgaps:
Branch: |
u/wishcow/ticket/15382 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by bhutz):
ok. I looked at the algorithm today and it looks fine. I also ran some
tests comparing against the `primes_of_bad_reduction` function for
projective morphisms and the results match (well, at least the primes
match).
In additional to my previous comments, I have two suggestions to make this
faster and one other comment
1) It seems like you could combine these two loops:
* for mon in mon_d:
* for f in newflist:
2) It also seems like you could always just work with the vector of
exponents instead of converting back and forth to monomials with mon_d;
i.e. don't use mon_d at all, just use degs.
3) You have a monomials() function, yet you don't use it in the main
macaulay_resultant function. Although with (2) you don't need it anyway.
You may however want to use some kind of iterator instead of making lists
of monomials since you don't need to keep them around after you've used
it. I'm sure `WeightedIntegerVectors` has an iterator of some kind.
It would be nice if there were a few comments in the code for
`macaulay_resultant` so that it is easier to follow.
--
Ticket URL: <http://trac.sagemath.org/ticket/15382#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
