#14358: Notebook server should run Java for JMol inside temporary directory
----------------------------------+----------------------------------
Reporter: ppurka | Owner: jason, mpatel, was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
----------------------------------+----------------------------------
Comment (by ppurka):
This patch looks good. I have tested it on sage-5.12.beta4 and
sage-5.13.beta1 with sagenb git and it works well. I have just one
comment:
The change to `fg` should be kept. I do not understand why it was set so
low at `fg=2`. The default image size seems to be not `fg=2` but rather
`fg=5`. The change is needed to ensure that the java process does not run
out of memory. For example `cube(figsize=40)` returns a memory error from
jmol now.
Do you plan to include the fix in 5.13? Or, do you want to make a git
patch out of it?
--
Ticket URL: <http://trac.sagemath.org/ticket/14358#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
