#14358: Notebook server should run Java for JMol inside temporary directory
----------------------------------+-------------------------------------
Reporter: ppurka | Owner: jason, mpatel, was
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.13
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Punarbasu Purkayastha
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
----------------------------------+-------------------------------------
Changes (by ppurka):
* status: needs_review => positive_review
* reviewer: => Punarbasu Purkayastha
Comment:
Replying to [comment:39 jdemeyer]:
> Replying to [comment:38 ppurka]:
> > The change to `fg` should be kept.
> I only removed code which was commented out, so I see no problem.
Oops. Sorry. I read and re-read it several times, but failed to notice
that it was commented code. That explains why the default size was 5 - I
was wondering why that if statement wasn't getting executed.
Then, the patch looks good to me. It is up to you if you want to include
it in 5.13 or later.
--
Ticket URL: <http://trac.sagemath.org/ticket/14358#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
