#14358: Notebook server should run Java for JMol inside temporary directory
----------------------------------+----------------------------------
       Reporter:  ppurka          |        Owner:  jason, mpatel, was
           Type:  defect          |       Status:  needs_review
       Priority:  major           |    Milestone:  sage-5.13
      Component:  graphics        |   Resolution:
       Keywords:                  |    Merged in:
        Authors:  Jeroen Demeyer  |    Reviewers:
Report Upstream:  N/A             |  Work issues:
         Branch:                  |       Commit:
   Dependencies:                  |     Stopgaps:
----------------------------------+----------------------------------

Comment (by jdemeyer):

 Replying to [comment:38 ppurka]:
 > The change to `fg` should be kept.
 I only removed code which was commented out, so I see no problem.

 > For example `cube(figsize=40)` returns a memory error from jmol now.
 That was already the case, it's not because of my patch.

 > Do you plan to include the fix in 5.13? Or, do you want to make a git
 patch out of it?
 I haven't decided. It looks a pretty safe patch, which isn't going to
 break anything else and only affects the notebook.

--
Ticket URL: <http://trac.sagemath.org/ticket/14358#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to