#14304: New implementation of unramified p-adics using FLINT and templates
-------------------------------------+-------------------------------------
Reporter: roed | Owner: roed
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: padics | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth, | Reviewers: David Roe, Julian
David Roe | Rueth
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/roed/ticket/14304 | d0baddeae085ce6aabd34178aceb98a83e7673e5
Dependencies: #12555, #12173 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by roed):
* status: needs_work => needs_review
Comment:
Replying to [comment:17 jdemeyer]:
> There is invalid use of `sig_on()` in many places. The following is
wrong:
> {{{
> sig_on()
> if condition:
> raise Exception
> sig_off()
> }}}
> You must put a `sig_off()` before the `raise` (or use `try`/`finally`).
Thanks. I fixed them.
> I also recommend to doctest these exceptions. The doctesting framework
catches such invalid use of `sig_on()`.
All of the instances I found were for problems that we never expect to
arise (out of memory errors, etc). So I don't see a reasonable way to
doctest these exceptions.
> I also don't like bare {{{except:}}} statements. Be explicit and use
{{{except BaseException:}}} or {{{except Exception:}}} instead.
I know. :-) I told Julian you didn't like them, but he claimed it was
okay since we raised after catching in each case. Anyway, I've changed
them to `except BaseException:`.
--
Ticket URL: <http://trac.sagemath.org/ticket/14304#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
