#14304: New implementation of unramified p-adics using FLINT and templates
-------------------------------------+-------------------------------------
Reporter: roed | Owner: roed
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.1
Component: padics | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth, | Reviewers: David Roe, Julian
David Roe | Rueth
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/roed/ticket/14304 | c647f4a1413547a47196f77acade2d7c45b46c28
Dependencies: #12555, #12173 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by roed):
> Nested exception blocks are generally hard to read, quadruply nested
exception try/except/finally blocks even more so. Besides the usual advice
of breaking long functions up into shorter ones, for the heap cleanup in
the face of exceptions make sure that invalid / not yet allocated pointers
are NULL. To simplify the cleanup part, `free(NULL)` is a no-op.
What about things like `mpz_clear`, `fmpz_clear` and `fmpz_poly_clear`?
If `a` is an `fmpz_poly_t` that has not yet had `fmpz_poly_init(a)` run on
it, won't `fmpz_poly_clear(a)` be a double free?
--
Ticket URL: <http://trac.sagemath.org/ticket/14304#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
