#14711: Weak references in the coercion graph
-------------------------------------+-------------------------------------
       Reporter:  jpflori            |        Owner:  davidloeffler
           Type:  defect             |       Status:  needs_review
       Priority:  critical           |    Milestone:  sage-6.2
      Component:  number fields      |   Resolution:
       Keywords:  memleak, number    |    Merged in:
  field, QuadraticField              |    Reviewers:  Nils Bruin, Jean-
        Authors:  Simon King,        |  Pierre Flori
  Travis Scrimshaw, Jean-Pierre      |  Work issues:
  Flori                              |       Commit:
Report Upstream:  N/A                |  ea58b22f0bf2652e7d04b3d55e6217dcb8732cdf
         Branch:                     |     Stopgaps:
  public/ticket/14711                |
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jpflori):

 Replying to [comment:219 nthiery]:
 >     Hi!
 >
 > Replying to [comment:215 tscrim]:
 > > I've actually changed `TriangularModuleMorphism` to print out a copy
 of itself when raising an error because I didn't like the WARNING message
 being displayed. (FTR, they were being used as expected since they are
 suppose to be internal coercions.)
 >
 > Sorry, I haven't been following the details.  Having to change the
 > code of existing morphisms when the usage is as expected feels like a
 > smell (one more thing to think about when using/implementing
 > morphisms). If I understand properly, in certain circumstances, one
 > has to make copies of morphisms. Is it described somewhere in the
 documentation what those
 Not with Travis last changes.
 Now the `coerce/convert_map_from` methods return "safe" objects for which
 the copying was automatically done.
 It's only the `_internal_` prefixed methods which return weakened objects
 but might be faster as no copies are involved.

--
Ticket URL: <http://trac.sagemath.org/ticket/14711#comment:220>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to