#15882: Implement a catalog for crystals
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: crystals catalog | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/crystals/catalog | 420cd330a8544371ab40dd8ccb507863cb5fda3f
Dependencies: #14275 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
Hey man.
I felt a bit trap when I noticed, after having spent quite some time
reading the diff, that the ticket did not only change what it claims....
Anyway.
I agree with everything I can understand (and "git diff --word-diff"
really is useful for tickets like that), but there are five things that I
cannot review:
- The "model" changes to
`/src/sage/combinat/crystals/highest_weight_crystals.py`
- This change
{{{
- if self.cartan_type().is_affine():
+ if not self.cartan_type().is_finite():
}}}
- This one
{{{
- return other.__lt__(self)
+ return self._list.__gt__(other._list)
}}}
- The definition of `KirillovReshetikhin` in catalog.py (and I don't think
that it is the right place to define it)
- Same for `RiggedConfigurations` in `catalog_kirillov_reshetikhin.py`
though the code is trivial>
I do not understand what it does, and though I thought I could review a
ticket that implements a crystal catalogs, I can't review these parts.
Soooo well. You can either remove them and I can set this ticket to
positive review, or someone else will do it.
There are broken doc links reported by `sage -docbuild reference/combinat
--warn-links html`. And I also add a commit to your branch to fix a typo
and a "double deprecation".
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15882#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
