#15882: Implement a catalog for crystals
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: crystals catalog | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/crystals/catalog | 968f9f6d6e48f4a16dfb79026805e73947ac8301
Dependencies: #14275 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooooo Anne !
> A lot of the changes look like simple line breaks. I strongly recommend
to take these out of this ticket since this pollutes the real changes that
were made and it does not enhance the code in any way. This will make it
much easier to review as well!
Well, actually "git diff --word-diff --color" helped me a lot there: it
understands that the difference is mostly line breaks, and so if a
LAAAARGE paragraph was split into many lines and a small modification is
made somewhere at the same time (here, a modification to a latex formula)
then the diff only displays the change to the latex formula, and you
basically don't see the line breaks. That's cool.
With GIT, it would have been better for the review to store all those
modifications in a specific commit, but this branch already has a lot of
commits and it makes it hard to review commit by commit.
But I reviewed all this already. If you can check what I was not qualified
to check above, as well as check that the classification of the
constructors in the crystals.<tab> object makes sense, then this ticket
can go.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15882#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
