#15882: Implement a catalog for crystals
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: crystals catalog | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/crystals/catalog | 968f9f6d6e48f4a16dfb79026805e73947ac8301
Dependencies: #14275 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yoooo Travis !
> Well, there were things that I wanted to touch up while I was making
sweeping changes.
Do you know the option "git add -p" ? This thing is fantastic ! In cases
like that, you can make all the changes you need to a file, and then split
it into different thematic commits.
Then they can become different tickets or just stay different commits...
But it lets you pick which changes (from the same file) you want to
include in the next commit, and that's cool. You can do all those changes
and decide later how you sort them.
> > - The definition of `KirillovReshetikhin` in catalog.py (and I don't
think that it is the right place to define it)
>
> This is the right place because it's just a function which redirects to
the correct class (in different files). IMO it's stupid (and potentially
confusing) to put it in `kirillov_reshetikhin.py` just to import it into
the catalog.
Won't you ever need some Sage code to call this function ? In this case it
would mean a "from sage.....crystals.catalog import KirillovReshetikhin",
which is a bit weird. It happens very often in the graph constructor that
we need to call other constructors. But well, if there is no "smart" code
in there after all, do as you wish.
> Here this should be here even more so because I want to reinforce that
we only want to construct the rigged configurations of a single KR crystal
(not as a tensor product thereof).
I first thought that "being a crystal" would reflect on the code, and that
it would inherit from some crystal class or parent or whatever. But I
really do not understand anything about crystals :-P
Have fun !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15882#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
