#15882: Implement a catalog for crystals
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: crystals catalog | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/crystals/catalog | 78489a65de542dfb00418fd9c707d498168bf918
Dependencies: #14275 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Hey Nathann,
Replying to [comment:12 ncohen]:
> I felt a bit trap when I noticed, after having spent quite some time
reading the diff, that the ticket did not only change what it claims....
Well, there were things that I wanted to touch up while I was making
sweeping changes.
> I agree with everything I can understand (and "git diff --word-diff"
really is useful for tickets like that), but there are five things that I
cannot review:
>
> - The "model" changes to
`/src/sage/combinat/crystals/highest_weight_crystals.py`
>
> - This change
> {{{#!diff
> - if self.cartan_type().is_affine():
> + if not self.cartan_type().is_finite():
> }}}
For reference: this is for better (future?) support for LS paths over
other indefinite types (ex. hyperbolic).
> - This one
> {{{#!diff
> - return other.__lt__(self)
> + return self._list.__gt__(other._list)
> }}}
After some though, I felt it was better to revert this.
> - The definition of `KirillovReshetikhin` in catalog.py (and I don't
think that it is the right place to define it)
This is the right place because it's just a function which redirects to
the correct class (in different files). IMO it's stupid (and potentially
confusing) to put it in `kirillov_reshetikhin.py` just to import it into
the catalog.
> - Same for `RiggedConfigurations` in `catalog_kirillov_reshetikhin.py`
though the code is trivial>
Here this should be here even more so because I want to reinforce that we
only want to construct the rigged configurations of a single KR crystal
(not as a tensor product thereof).
> I do not understand what it does, and though I thought I could review a
ticket that implements a crystal catalogs, I can't review these parts.
Thank you for your review thus far.
> There are broken doc links reported by `sage -docbuild
reference/combinat --warn-links html`. And I also add a commit to your
branch to fix a typo and a "double deprecation".
I've done what I can about them.
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/ticket/15882#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
