#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
Reporter: vittucek | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vít Tuček, Travis | Reviewers:
Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 612db215e7e89687f2dc5af38ce0915af16cc49a
public/combinat/root_systems/marked_types-15948| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vittucek):
Great!
Replying to [comment:18 tscrim]:
> Okay, done with the refactor and creating the `type_marked`. I couldn't
get your latex to work, so I just implemented a custom help for the marks
(cross outs). It's now setup so it's easy enough to add additional
functionality if anyone wants it.
>
Is this feature discoverable by a user? Shouldn't we add some examples to
`CartanType`'s docstring?
You've missed the bugfix for docstring regarding our convention for Dynkin
diagrams (see commit 74c6d23eb28fd192b70e2219030d6ad60fcb9f0f).
> I've also done some fixing up of the way we print the Dynkin diagram
ascii art, so with labels up to length 3 (almost 4 really), it looks nice.
I refactored `type_dual` and `type_relabeled` to inherit from a common
class `CartanType_decorator` which acts as a decorator class and redirects
most methods to the base Cartan type. I've set the (implicit) order of the
decorators as
> {{{
> dual <- relabelled <- marked
> }}}
> where the first one was what was there previously. I also gave a
`relabel` method to Dynkin diagrams and Cartan matrices. I think that's
all, but I might be forgetting something. If we're happy with my changes,
then it's a positive review.
Would it be possible to add one more layer for weighted Cartan types? I
mean my original motivation for this patch was to be able to produce
diagrams for representation of homogeneous vector bundles which I can't
really do now. :)
I'd add this feature myself, but I am still struggling with understanding
the current code. Is there some programmers documentation or design
documents that would help me?
--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
