#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
Reporter: vittucek | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vít Tuček | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vittucek/ticket/15948 | 91981c1e5a5834ade692466334e7fdf89093a058
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vittucek):
Replying to [comment:16 tscrim]:
> Yes there is, but finals week trumps Sage work. However from looking at
the code, I think there is significant issues when dealing with non-
standard indexing sets (which we should support).
>
Would it help to refactor node_labels` and `crossed_nodes` into
dictionaries as I suggested in comment 11?
> I'm going to cannibalize your branch into a new one where I'm going to
create a new class in `type_marked.py` for types with marked nodes and add
a proper relabel to `DynkinDiagram`. I should have it done in an hour or
so.
>
> EDIT - So basically we want relabellings and markings to act as
decorator classes (as per the design pattern). This will take some
(moderate) refactoring, but it will simplify the resulting code and make
it easier for similar future additions.
Great. Thank you. I am just not sure how do we accomplish crossed nodes
and weight labels at the same time. Multiple inheritance?
By the way, last week I've stumbled upon some articles about nilpotent
orbits where they use Dynkin diagrams with labels and call them Weighted
Dynking diagrams. So maybe use `WeightedCartanType` and
`WeightedDynkinDiagram` for the guys with labels and `MarkedCartanType` &
`MarkedDynkinDiagram` for crossed nodes? I can imagine that someone would
want to use different markings than crosses which would amount to another
round of digging into the TikZ documentation and parameter tweaking in all
those `_latex_...` methods.
--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
