#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
Reporter: vittucek | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vít Tuček, Travis | Reviewers:
Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 612db215e7e89687f2dc5af38ce0915af16cc49a
public/combinat/root_systems/marked_types-15948| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'V\xedt Tu\u010dek, Travis Scrimshaw', 'oldvalue':
u'V\xedt Tu\u010dek'}):
* status: new => needs_review
* commit: 91981c1e5a5834ade692466334e7fdf89093a058 =>
612db215e7e89687f2dc5af38ce0915af16cc49a
* branch: u/vittucek/ticket/15948 =>
public/combinat/root_systems/marked_types-15948
* author: Vít Tuček => Vít Tuček, Travis Scrimshaw
Comment:
Okay, done with the refactor and creating the `type_marked`. I couldn't
get your latex to work, so I just implemented a custom help for the marks
(cross outs). It's now setup so it's easy enough to add additional
functionality if anyone wants it.
I've also done some fixing up of the way we print the Dynkin diagram ascii
art, so with labels up to length 3 (almost 4 really), it looks nice. I
refactored `type_dual` and `type_relabeled` to inherit from a common class
`CartanType_decorator` which acts as a decorator class and redirects most
methods to the base Cartan type. I've set the (implicit) order of the
decorators as
{{{
dual <- relabelled <- marked
}}}
where the first one was what was there previously. I also gave a `relabel`
method to Dynkin diagrams and Cartan matrices. I think that's all, but I
might be forgetting something. If we're happy with my changes, then it's a
positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=c655d510769d74bd31fb6e395a88eab35ca0998f
c655d51]||{{{Implemented marked Cartan types and refactored common
code.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=80684be2a593638f22cacc79bbe408a2138e3097
80684be]||{{{Fixed last doctests and added to full coverage.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=612db215e7e89687f2dc5af38ce0915af16cc49a
612db21]||{{{Fixed last failing doctest.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
