#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
       Reporter:  vittucek           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vít Tuček, Travis  |    Reviewers:
  Scrimshaw                          |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  612db215e7e89687f2dc5af38ce0915af16cc49a
  public/combinat/root_systems/marked_types-15948|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Replying to [comment:19 vittucek]:
 > Is this feature discoverable by a user? Shouldn't we add some examples
 to `CartanType`'s docstring?

 Yes via `marked_nodes`. However we should add something to the doc of
 `CartanType` (I thought I did, but I guess not).

 > You've missed the bugfix for docstring regarding our convention for
 Dynkin diagrams (see commit 74c6d23eb28fd192b70e2219030d6ad60fcb9f0f).

 I'm not convinced yet that it is incorrect, much less that your proposal
 makes anything better. I will look at it more closely and think about it
 today/tomorrow (unless Dan or Nicolas, you have an opinion on this?).

 > Would it be possible to add one more layer for weighted Cartan types? I
 mean my original motivation for this patch was to be able to produce
 diagrams for representation of homogeneous vector bundles which I can't
 really do now. :)
 >
 > I'd add this feature myself, but I am still struggling with
 understanding the current code. Is there some documentation for
 programmers or  design documents that would help me?

 IMO we should do this in a follow-up ticket as this one has a lot going on
 to begin with. However it should be easy enough to do by adding a
 class/file similar to `type_marked.py` and another method to the base
 `CartanType_abstract` class.

--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to