#2516: generalized hypergeometric functions should be implemented
-------------------------------------+-------------------------------------
       Reporter:  ddrake             |        Owner:  cwitty
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  symbolics          |   Resolution:
       Keywords:  hypergeometric     |    Merged in:
        Authors:  Fredrik            |    Reviewers:  Ralf Stephan
  Johansson, Eviatar Bach, Ralf      |  Work issues:
  Stephan                            |       Commit:
Report Upstream:  N/A                |  ebe4c6a12c88cf6fdf0e7eb7b43bcfe05dcab8a4
         Branch:                     |     Stopgaps:
  u/rws/generalized_hypergeometric_functions_should_be_implemented|
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by nbruin):

 OK, the problem is in `ext.fast_callable.function_name`, which gets called
 by `sage.ext.fast_callable.ExpressionCall.__repr__`. with as argument the
 "function" component of the ExpressionCall. The problem is: an expression
 doesn't have a `__name__`. So you end up finding a `__name__` somewhere
 higher in the inheritance. You just end up putting an extraneous attribute
 on the expression. To illustrate the nasty side-effect:
 {{{
 sage: h =  hypergeometric([],[],x)
 sage: h.__name__
 'CommutativeRings.element_class'
 sage: from sage.ext.fast_callable import ExpressionTreeBuilder
 sage: etb = ExpressionTreeBuilder(vars=['x'])
 sage: _ = h._fast_callable_(etb)
 sage: h.__name__
 'hypergeometric((), (), x)'
 }}}
 As you see, `_fast_callable_` now has a side-effect on `h`!

 A better solution would be to adapt the routine
 `ext.fast_callable.function_name` (or the way it gets used). It's clear
 you're now feeding it things it wasn't designed for.

--
Ticket URL: <http://trac.sagemath.org/ticket/2516#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to