#16275: Hom: introduce a check argument to simplify the unpickling detection
logic
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: homset, pickling | Merged in:
Authors: Nicolas M. | Reviewers: Simon King
ThiƩry, Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | e1e916cde347deac1df9079f7ec856184e3862bf
u/SimonKing/ticket/16275 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:34 SimonKing]:
> Really? This sounds ugly to me. And the purpose of the pickle jar is not
"go search for the potential problem". IF there will be a problem in
future then the pickle jar will inform us.
It will inform us indeed. But if as a developer I wonder why all this
logic is needed, and want to experiment on a concrete example, I need to
dig
in the jar to find the pickle that demonstrates it. In short, it keeps the
tests
close to the code.
But yes, I agree, it's a bit cryptic. And it's not (yet?) common usage
even though it's not unprecedented either (see __setstate__ in
combinat/partition.py or combinat/ribbon_shaped_tableau.py).
> Ahem, I clearly wrote `See trac #16275 and #14793.`
There was a race condition; I still was on the previous commit :-)
Cheers,
--
Ticket URL: <http://trac.sagemath.org/ticket/16275#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.