#16295: Faster is_orthogonal_array
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 0d5c222cc78546cada8ae505197f429781b9595c
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16295 |
Dependencies: |
#16236 |
-------------------------+-------------------------------------------------
Comment (by brett):
Nathann,
The code looks good and I have tested on an example different from your
doc test.
The following run fine:
make,
doc-test,
docbuild html,
code coverage is 100%
I had trouble making the pdf documentation and then went back to devel
branch to check it worked Ok there. It did and then when I moved back to
u/ncohen/16295 it worked. I am not sure what happened
I think this needs two things:
- it needs to be as consistent as possible with the purely python version
inside orthogonal_arrays.py. That is, it will react the same way on the
same input. This change should be done and then a doc-test written to
verify it.
- it needs to have a doctest that demonstrates the speed improvement that
cycthon gives over the purely python version inside orthogonal_arrays.py.
--
Ticket URL: <http://trac.sagemath.org/ticket/16295#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
