#16295: Faster is_orthogonal_array
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 0d5c222cc78546cada8ae505197f429781b9595c
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16295 |
Dependencies: |
#16236 |
-------------------------+-------------------------------------------------
Comment (by brett):
Sorry, I had changed branches and then opened orthogonal_array.py in an
editor and so thought is_orthogonal_array was still there.
Here is my timing data
with Cython:
sage: time is_orthogonal_array(OA,8,9)
CPU times: user 0 ns, sys: 0 ns, total: 0 ns
Wall time: 27.2 µs
False
sage: time is_orthogonal_array(OA,12,11)
CPU times: user 0 ns, sys: 0 ns, total: 0 ns
Wall time: 239 µs
True
with Python:
sage: time is_orthogonal_array(OA,8,9,2)
CPU times: user 0 ns, sys: 0 ns, total: 0 ns
Wall time: 29.1 µs
False
sage: time is_orthogonal_array(OA,12,11,2)
CPU times: user 12 ms, sys: 4 ms, total: 16 ms
Wall time: 13.1 ms
True
this shows a significant improvement in speed.
However I think this needs to be fixed:
sage: is_orthogonal_array(OA,12,11,3)
True
If it is passed t=3 it should at least alter the user that it is going to
override this with t=2
Here is what I think should be done:
- fix t=3 bug
- remove "any" as Vincent suggested
- implement a doc test for
- all your bad input/format tests
- memory test
- t>2 test
--
Ticket URL: <http://trac.sagemath.org/ticket/16295#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
