#16295: Faster is_orthogonal_array
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 0d5c222cc78546cada8ae505197f429781b9595c
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16295 |
Dependencies: |
#16236 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Hellllooooo !!
> I had trouble making the pdf documentation and then went back to devel
branch to check it worked Ok there. It did and then when I moved back to
u/ncohen/16295 it worked. I am not sure what happened
Yeah, we had the same problems just one hour ago when Volker tried to
merge #16277 or #16235... And it does not happen again because Sphinx is
totall unreliable. I expect it to ocome from the dependencies, not from
this ticket
> I think this needs two things:
>
> - it needs to be as consistent as possible with the purely python
version inside orthogonal_arrays.py. That is, it will react the same way
on the same input. This change should be done and then a doc-test written
to verify it.
Once this patch is applied there is no python version inside of
`orthogonal_arrays.py`, as this patch removes it. We can add any doctest
you want, but what could it be ? Remember that this function is already
tested a LOT by all constructions of OA/TD/MOLS as it is run on those
instances every time one is built.
> - it needs to have a doctest that demonstrates the speed improvement
that cycthon gives over the purely python version inside
orthogonal_arrays.py.
Once more, this function removes the purely python one.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16295#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
