#16332: Game Theory: Build capacity to calculate Shapley value of cooperative
games.
-------------------------------------+-------------------------------------
       Reporter:  vinceknight        |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.3
      Component:  PLEASE CHANGE      |   Resolution:
       Keywords:  Game Theory,       |    Merged in:
  Cooperative Games                  |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  9d0cc2370d1a2e32d29c5e6bbf1ab878549c1043
  
u/jcampbell/game_theory__build_capacity_to_calculate_shapley_value_of_cooperative_games_|
     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by kcrisman):

 Here are a few brief comments to get going.
 * One thing I found odd - if you look at
 http://git.sagemath.org/sage.git/tree/src/doc/en/reference then you'll see
 that most modules only have a one-liner for the
 src/doc/en/reference/game_theory/conf.py type file.  My guess is that is a
 good idea, though you'll want to try to make sure.
 * Probably brief versions of the (great) descriptions of the methods in
 the main doctoring could be added to the individual method docs, e.g.
 {{{
 sage: integer_game.nullplayer?
   Returns True if the current payoff_vector possesses the null player
    property.
 ...
 }}}
    is pretty minimalist.
 * Documentation won't build, perhaps there is something needed in a
 manifest somewhere.
 {{{
 $ ./sage -docbuild reference html
 [dynamics ] WARNING: intersphinx inventory
 '/Users/.../sage/src/doc/output/html/en/reference/game_theory/objects.inv'
 not fetchable due to <type 'exceptions.IOError'>: [Errno 2] No such file
 or directory: Error building the documentation.
 }}}
   This could just be my problem, of course.
 * Are your LaTeX issues due to using dollar signs instead of single
 backticks?  (Since I can't actually build the documentation.)
 * Or, you may be interested in using the `:math:` - see
 [http://sagemath.org/doc/developer/coding_basics.html#latex-typesetting
 here], though I don't see anything obviously wrong.
 * If you are using a different source for Shapley, maybe you should
 mention your source.  Also (though this is more minor, since this is a
 first try!), did you compare timings for the two different things in
 Python?  Creating lots of power sets and factorials looks as scary as what
 you did before, but maybe it isn't.

--
Ticket URL: <http://trac.sagemath.org/ticket/16332#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to