#16332: Game Theory: Build capacity to calculate Shapley value of cooperative
games.
-------------------------------------+-------------------------------------
       Reporter:  vinceknight        |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  PLEASE CHANGE      |   Resolution:
       Keywords:  Game Theory,       |    Merged in:
  Cooperative Games                  |    Reviewers:  Karl-Dieter Crisman,
        Authors:  James Campbell,    |  Travis Scrimshaw
  Vince Knight                       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  1d4cb9318d8cda41082fcefe01f072237ffd79e9
  public/game_theory/Shapley_value_coop_games-16332|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'James Campbell, Vince Knight', 'oldvalue': ''}):

 * status:  needs_work => needs_review
 * commit:  9d0cc2370d1a2e32d29c5e6bbf1ab878549c1043 =>
     1d4cb9318d8cda41082fcefe01f072237ffd79e9
 * reviewer:   => Karl-Dieter Crisman, Travis Scrimshaw
 * branch:
u/jcampbell/game_theory__build_capacity_to_calculate_shapley_value_of_cooperative_games_
     => public/game_theory/Shapley_value_coop_games-16332
 * author:   => James Campbell, Vince Knight


Comment:

 I've fixed up the documentation, both in formatting and content (there
 were a bunch of typos). So take a look, it has most types of formats that
 you'll ever need. I also simplified the computation of the Shapley value
 to use `binomial`, so we (generally) don't have to do large cancellations.
 With this change alone I got a 10~15% speedup, plus I did some other
 (micro)optimizations. I don't know the logic behind the math, but the code
 does what is stated in the doc and agrees with the reference. However if
 you could provide a reference for the alternative form of the Shapley
 value, then I think we can set this to a positive review as I think I've
 also addressed all of Karl-Dieter's comments.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=4745c46aaf5e08ae4c0e9800171f79afb425d85d
 4745c46]||{{{Merge branch
 
'u/jcampbell/game_theory__build_capacity_to_calculate_shapley_value_of_cooperative_games_'
 of trac.sagemath.org:sage into
 public/game_theory/Shapley_value_coop_games-16332}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=135202713a3b0454aa95b896c2c308a8af6d8059
 1352027]||{{{Fixed up documentation and some other misc speedups.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=1d4cb9318d8cda41082fcefe01f072237ffd79e9
 1d4cb93]||{{{Adding additional doc to other functions.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16332#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to