#16347: Wilson's constructions of OA with 2 truncated groups
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16347 | d93a97c5abb48f3f5067c516ca0b133b52146da4
Dependencies: #16373 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yo !
> More changes on public if you agree...
They look good ! Except for tho things :
{{{
Finds a wilson decomposition to build an `OA(k,n)` with one truncated
column
}}}
Here one can understand that the purpose of the function is to build a
truncated OA....
{{{
+ Then there exists an `OA(k,rm+\sum u_i)`. This construction is a
+ straightforward generalization of Lemma 3.16 of [HananiBIBD]_.
}}}
It is only straightforward when one tells you what there is to find `:-P`
> - I do not understand why you output `n` in
`find_wilson_decomposition_with_one_truncated_group`
> - I do not understand why you output `k` in
`find_wilson_decomposition_with_two_truncated_groups`
Historical resons I would say. You just changed the inputs used by
Wilson's construction, I did it too before, and I did not think necessary
to update the related functions ...
> I would rather output `(r,m,(r1,))` and `(r,m,(r1,r2))`. That way the
call would be uniform in `orthogonal_array`... and you should decide
between `r1,r2` and `u1,u2`.
If you sleep better this way you can update them. Really it is only
internal stuff, I thought that we could make them private functions at
some point.. I do not care as long as the designs are produced `:-P`
By the way, #16500 defines a `find_recursive_construction` is
`orthogonal_array_recursive.py` which calls all recursive constructions.
The plan was to move the two `find_wilson_decomposition*` to this file
later, and this will require to change their output again.
> PS: right now I am going to teach ctypes and cython, so I will not look
at it again until tonight.
Good luck ! And show them
{{{
sage -cython -a my_file.pyx # produces a html file whose lines are
clickable
}}}
that's really cool !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16347#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
