#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/gagern/ticket/16533 | 51007fbf59595127ed4b784155e91d78ebb52b2a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
Replying to [comment:8 jdemeyer]:
> I think fixing the notebook animate bug, the `<video>` tag and the APNG
support should be 3 different tickets.
I guess I could try to split my modifications up. But there are several
parts where I would not know where to put them.
* Several documentation improvements are not directly related to either of
these issues. Should I file yet another ticket?
* And this whole modification of having `show` call `save` is used for
APNG and <video>, so where should it go? Can I create a branch which
contains this change, and then use that branch for both APNG and <video>?
* The last commit, about inlining animations in tables, is again distinct,
even though it was included in the ticket:7298 patch as well. Separate
ticket as well?
The way I see it at the moment, we have 5 distinct modifications, two of
which share a commit:
* Notebook:
* [/sage.git/commit/?id=9374cff6d1dbc7ca44749c36a1e5b4693e81819b Create
HTML to embed generated GIF in notebook]
* [/sage.git/commit/?id=84886ce6d5d46ee4940f12e7ea508e885ba17ebb Return
path to generated file]
* [/sage.git/commit/?id=8199b0237d6e5053932bd609ea941a02f993b36d Avoid
leaking animation files]
* Common APNG and <video>:
* [/sage.git/commit/?id=1d29d17be571d24af57c85aedb2c31e9e5a1277f Base
Animation.show on Animation.save, and pass more arguments]
* APNG support:
* [/sage.git/commit/?id=1f7de6eb7fa8bffdf54e1a73d6c8a0ae4051ffd1 Add
APNG support]
* [/sage.git/commit/?id=f3a5b9010cf47bcca463360a2e10e6241c7628be Avoid
multiple acTL hunks in APNG file]
* [/sage.git/commit/?id=4c9a4910ad273dcb0f6226ef00274267f0192602 Turn
generator into list when rendering frames]
* [/sage.git/commit/?id=57254600199330cece33a867355183730c611218 Fix doc
test]
* Documentation improvements:
* [/sage.git/commit/?id=0c21bd8d4257cb8c96560880a84e827552324378
Improved documentation]
* <video> tag support:
* [/sage.git/commit/?id=3edfb7f99fc79edf4716eb2e80f927213b9f86cb Support
HTML5 video tag]
* [/sage.git/commit/?id=b8a3c7c3affeffea7d3054e69f18065204c5d930 More
control over video tag attributes]
* Tables:
* [/sage.git/commit/?id=51007fbf59595127ed4b784155e91d78ebb52b2a Inline
animations in tables]
It would take some time to work out whether these branches each make sense
on their own. I'd prefer to only invest that effort if I know it is
actually needed. Would you be willing to review some of these aspects,
Jeroen? If so, that would be one reason for formatting things in the way
you prefer.
--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
