#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/gagern/ticket/16533b | 0325ee23e8e339d7ad2a3f36f6c0b03da7a0cafb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
Replying to [comment:16 kcrisman]:
> Okay, I'm 99% sure that #12827 caused this.
I agree, namely the two instances where
`sage.misc.temporary_file.graphics_filename` got replaced by
`tmp_filename`.
> Do we really need all this infrastructure for this to be fixed? (I'm
not saying we don't, just checking.)
Not neccessarily. We could get away with just replacing `tmp_filename` by
`graphics_filename` if we are in the `EMBEDDED_MODE` case. This is
essentially undoing the `graphics_filename` removal from #12827. Although
I would advise against unconditionally using `graphics_filename`. I did
that at some point, and suddenly my test suite started bleeding files into
the current working directory from where I ran the tests. That's why I
wrote
[http://git.sagemath.org/sage.git/commit/?id=8199b0237d6e5053932bd609ea941a02f993b36d
8199b02] in my now-superseded branch.
The reason to have all this infrastructure is twofold. On the one hand, it
also facilitates later improvements, like #7298 and #16571. On the other
hand, it makes code more similar to `Graphics.show`, which helps
maintainability. So I really suggest you compare `Animation.show` to
[http://git.sagemath.org/sage.git/tree/src/sage/plot/graphics.py#n1785
Graphics.show] when reviewing this. There you see common aspects:
* Delegating to save
* Passing kwargs
* Using `graphics_filename` only in the embedded case
I think this commonness justifies the larger footprint of my modification,
but if you want to aim for a fix which is as small as possible, then
concentrating on the `tmp_filename` vs. `graphics_filename` distinction is
sufficient.
--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
