#16598: Useless new classes and a replacement for _check_pbd
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16598 | 1a5a4b8203a2ad104d617a150e2029dbe3a315b1
Dependencies: #16553 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
> I added a little commit of cleaning (and also replace the deepcopy by
something more explicit) at `u/vdelecroix/16598`.
Looks good !
> The semantic of `copy=True/False` is currently not the same with
`.blocks()` and `.groups()`. I decided [...]
Oh, cool ! Actually I thought it was written the way I first wrote
`.groups` and I thought that it was not the correct way to implement it,
and so I implemented it this way to follow what I thought was the previou
choice. I prefer it this way too ! Fixed.
> In the function `is_group_divisible_design` it is assumed that the
ground set is `{0, ..., v-1}` (which is just find since it is called with
the internal data from `GroupDivisibleDesign`). It would be cool to
specify it in the doc...
It was specified in the documentation of the mandatory argument `v`, but I
added another occurrence in the one-line description of the function
> What is the point of `matrix[i*n+j] != <unsigned short> -1` (in
`is_group_divisible_design`)?
Leftover from a previous implementation. Removed !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16598#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
